Stephan Bergmann wrote:
[...]
Another problem that only dawned on us recently is the following: The OOo source includes a number of external projects that deliver C/C++ headers that are included from other modules. To suppress warnings from such headers, patches have been included for some of those external projects on warnings01. However, some people build OOo in such a way that they use system-supplied alternatives of those external projects, so that the patches will have no effect for them. That means that switching on "warnings are errors" can break such builds (although the "official" OOo builds would succeed). The relevant patch files, until now, are
  boost/boost-1.30.2.patch
  boost/spirit-1.6.1.patch
  icu/icu-2.6.patch
  neon/neon.patch
  python/Python-2.3.4.patch
  sablot/Sablot-0.52.patch
  stlport/STLport-4.0.patch
  stlport/STLport-4.5-0119.patch
If anybody has an elegant solution to this problem, that would be great.

The most pragmatic approach (and the one at least I have taken during the last couple weeks when working on warnings01) is probably to not touch the headers delivered from external projects, but instead use pragmas at the places where those headers are included to disable warnings from within the headers. In case a delivered header is included in multiple places, this can be made DRY by creating a new header that does the pragma stuff and then includes the original header.

-Stephan

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to