Hi Mathias, On Wednesday, 2007-03-07 23:28:04 +0100, Mathias Bauer wrote:
> > January 1, 1601 is the base of Windows file time, as used in OLE > > SummaryInformation. > > So it makes sense to use this define when importing OLE > SummaryInformation. The question remains how we should handle this in > the rest of the code. That particular date not as anything special in another context than the OLE / Windows file time mentioned. In other context it is just another valid date. > We could either use the same approach for css.util.DateTime also but > then we should document it in the IDL file. Or we should remove the > define for an invalid timestamp and instead use a static IsInvalid() > function that checks for both values (the OLE one as well as the "void" > case for css.util.DateTime). If using it at all (I'd prefer if we didn't) we should restrict it to an INVALID_WINDOWS_FILE_OR_OLE_TIMESTAMP or such and not add it to a general IsInvalid() method. > I don't believe that using a TimeStamp with > nDate=0L (that's what we get when we convert a "void" css.util.Datew to > a "tools" Date) can be anything else than an invalid Date. Seconded. Neither the proleptic Gregorian nor the proleptic Julian calendar use 0-0-0 as date (or any date in a year 0). > I would prefer the second way as using gthe Windows file time in our IDL > looks a bit strange. > > In case noone objects I will create an issue to change this as described. Agreed. Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to this [EMAIL PROTECTED] account, which I use for mailing lists only and don't read from outside Sun. Thanks. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
