Hi, In message "Re: [dev] anonymous namespace", Stephan Bergmann wrote... >Takashi Ono wrote:
>> >> Maybe it is better to move the contents of dbaccess/source/core/misc/propertybag.hxx >> and ucb/source/inc/regexpmap.tpt to the main source respectively. They seem >> to be >> used in only single main source. >> >> In the case of sd/source/ui/inc/DrawController.hxx, the only solution not >> to violate >> ODR seems to be making implementation visible. However, it may cause no >> problem if >> the pointers or the references are not passed across the translation units. > >Yes, these cases should be fixed (even if ODR violation would be >harmless). Do you take care of it? > I have fixed dbaccess/source/core/misc/propertybag.hxx and sd/source/ui/inc/DrawController.hxx. I will raise patch issues for them. As long as ucb/source/inc/regexpmap.tpt is concerned, it is not so easy. Actually ucb/source/inc/regexpmap.tpt is including explicit template instantiations and the original template haeder is included in more than one source although ucb/source/inc/regexpmap.tpt is included in only one. If another code use exactly the same instantiation, it will be a case of concern. I think we should move implementation out of anonymous namespace also for this case but I have not tested yet. ---- Takashi Ono(HK Freak) mailto:[EMAIL PROTECTED] or [EMAIL PROTECTED] (Personal Address, checked every morning/evening and holidays) mailto:[EMAIL PROTECTED] (Address for business, checked every working days) http://www.hkfreak.net --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
