2008/9/5 Eike Rathke <[EMAIL PROTECTED]>: > Hi Nguyen, > > On Thursday, 2008-09-04 12:32:48 +0900, Nguyen Vu Hung wrote: > >> I've noticed unused variables in the code, implicit declaration of >> function or possibly dangerous type casting... when compiling >> DEV300_m29. >> >> It doesn't hurt but IMO, expunge what we don't need in the code is not >> a bad idea. > > See comment in soltools/mkdepend/makefile.mk: > > | # "mkdepend" is written in K&R style C. Modern compilers will generate > | # lots of warning. There is no point in cleaning this up, so we just > | # ignore warnings > > In the case of "implicit declaration" here defining > NeedVarargsPrototypes, see def.h, in makefile.mk's CDEFS may help. If > you like try that out and if it silences the messages down and works > file a patch issue with the 'tools' project where module 'soltools' is > part of. mkdepend is just one part of OOo. It just works. Warning are annoying but I we can live with it.
Unused variables are different: They take up memory. Here, by "warning", I am talking about both general cases and some particular cases. I have not yet seen all the warning in the dmake log file but first 10000 lines of them are quite interesting to look at. Just grep -i warning. Lots of. > Btw, it also doesn't hurt to include the names of module and source code > file compiled when posting build messages ;-) I've posted all that dmake has outputed. http://aoclife.ddo.jp/~vuhung/foss/src/DEV300_m29/dmake_20080904_1155.log -- Best Regards, Nguyen Hung Vu ( Nguyễn Vũ Hưng ) [EMAIL PROTECTED] , YIM: vuhung16 , Skype: vuhung16dg Japan through an eye of a gaijin: http://www.flickr.com/photos/vuhung/tags/fav/
