On Mon, Oct 20, 2008 at 01:55:11PM +0200, bjoern michaelsen - Sun Microsystems - Hamburg Germany wrote: > > - I like the module organization section, but would add more, like > > e.g. the convention of building libs one directory up (for > > Writer), what generally the util & prj dirs are for & what they > > should contain. > Yes, I would love that too, however my idea of how this is supposed to > look like is only vague. Maybe someone from RelEng might step up and add > a few lines about how a "wellformed module" is layed out? > +1 - IIRC there's even an old request pending from when we did the coding standards ;)
> > Maybe keeping filenames all-lowercase is a bit anachronistic - > > but keeping them [a-zA-Z0-9.-] seems still crucial. > True. OTOH, for example Subversion has some interesting behaviour with > upper/lowercase filenames on Windows (commit "svn mv SomeFile.cxx > somefile.cxx" on unix and update on Windows). > I see. But this surely doesn't apply to all-new files, no? (is there an svn bug filed for this already?) > > - the formatting section is probably the most controversial one > > (and that's one of the reasons we didn't specify that in the > > coding standards). Either skip it as well, or at least refrain > > from catering for tools like lxr (which is obsolete now anyways). > > The most frequent reader of the code is still you, and your > > fellow devs (using a proper editor) - strive to make code readable > > *there*. > Well, lets just call them recommendations. If you do not have a > stylistic preference on a topic, you could use those for guidance. > Ok, then fine with that - except that I'd veto the one-line if-statement (prevents setting a breakpoint there for various frontends), and the non-alignment of statements (proper editors do that en passant, and it's quicker to parse for the eye). [Now you see where it leads, when trying to agree on formatting ;)] > I removed the camtrip.org-link. Please feel free to add recommandarions > about SAL_NO_VTABLE, SAL_DLLPUBLIC_EXPORT, SAL_DLLPUBLIC_IMPORT and > SAL_DLLPRIVATE. > Will do - seeing that you're working on it, can you ping me for a handover in private? > While it is true that code by one person with any sense of > style is perfectly readable, it also true that 200 persons with any > sense of style working in the same codebase will lead to documents > formatted different every five lines, severely reducing readability. > Well, then clue-bat them with the CodingStandard, which you quoted so appropriately in your Naming Conventions section. :) Cheers, -- Thorsten --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
