wtfzambo opened a new issue, #116: URL: https://github.com/apache/openserverless/issues/116
## Why you need it? During deploy, package args are detected by either this `#-` or this `//-` pattern. However, all python formatters (e.g. black or ruff) format comments by adding a space between `#` and what comes after. This breaks detection of the args and therefore breaks the deploy. Unfortunately, adding a simple condition to check also on `# -` risks to overlap with normal python comments that may start with the same characters for whatever reason. ## How it could be? I can think of 2 solutions: 1. Increase the complexity of the pattern. Simple, but not super desirable because it requires more typing and possibly using regex (🤮). 2. Move the deploy args to a dedicated file within the package (e.g. `args.json`). More solid approach, but requires extra steps (and there might be other implications I'm not aware of). ## Other related information Both suggestions are breaking changes for current users of openserverless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openserverless.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
