wtfzambo commented on PR #98: URL: https://github.com/apache/openserverless-task/pull/98#issuecomment-2984511980
@almartino thanks for taking the time to work on this! This is pretty much the idea I had in mind when I opened the issue (and executed way better than I would have been able). I just tested it on the [openserverless tutorial](https://openserverless.apache.org/docs/tutorial/packaging/) and I encountered just a small issue: ```txt error: Unable to delete package 'contact': Package not empty (contains 2 entities). Set force param or delete package contents. ``` The 2 entities are the sequences: `submit-write` and `submit-notify`. Maybe _sequences_ should be added too to `deployment.json`? Regarding your questions: > 1. could be useful to automatically add the .ops dir to the .gitignore file when creating a project? I think `.ops` dir should be version controlled 🤔. Imagine a CICD pipeline running either `ops ide deploy / undeploy`. What would happen if it didn't have access to `deployment.json`? > 2. should we make this retro compatible for projects prior to this fix? I wouldn't bother: the `deployment.json` file can be generated on an existing project by running `ops ide deploy` once, which will just update the current packages and actions AND generate the file. I didn't encounter other issues (albeit, I tested it on a simple deployment). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openserverless.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
