Hi all,
I found an issue in the build pipeline. The operator Dockerfile hardcodes the 
default registry:
ARG 
OPERATOR_IMAGE_DEFAULT=registry.hub.docker.com/apache/openserverless-operator
The root Taskfile reads this value directly via awk:
OPERATOR_IMG:  sh: awk -F= '/ARG OPERATOR_IMAGE_DEFAULT=/ { print $2 ; exit }' 
olaris-op/Dockerfile
This means any contributor who wants to build locally with a different 
registry(e.g. a local MicroK8s registry, a personal ghcr.io, or a corporate 
registry)is forced to modify the Dockerfile locally without being able to 
commit the change.There is currently no supported way to override this value 
without touchingversioned files.
Proposed solution: read OPERATOR_IMAGE_DEFAULT from an environment variable ora 
.env file, with the Apache registry as fallback. For example in the Taskfile:
OPERATOR_IMG:  sh: |    if [ -n "$MY_OPERATOR_IMAGE" ]; then      echo 
"$MY_OPERATOR_IMAGE"    else      awk -F= '/ARG OPERATOR_IMAGE_DEFAULT=/ { 
print $2 ; exit }' olaris-op/Dockerfile    fi
This would allow contributors to set MY_OPERATOR_IMAGE in their local 
.envwithout modifying any versioned file.
Happy to submit a PR once the preferred approach is confirmed.
Thanks,Alessio Marinelli

Reply via email to