pjfanning opened a new pull request, #133: URL: https://github.com/apache/openserverless-operator/pull/133
## What Two related fixes found while verifying the 0.9.0-incubating RC5 source release. ### 1. Restore the cert-manager copyright notice `deploy/cert-manager/cert-manager.yaml` is byte-for-byte the cert-manager **v1.10.1** release manifest (verified by diff against the GitHub release asset), but its upstream header ``` # Copyright 2022 The cert-manager Authors. # Licensed under the Apache License, Version 2.0 ... ``` had been replaced by the ASF header. Apache-2.0 §4(c) requires keeping that notice when redistributing. The four copies of the same manifest (v1.11.0) in `openserverless-task` kept it. This PR puts it back directly below the ASF header, matching the layout used there. The manifest body is unchanged. ### 2. Attribute the third-party manifests in LICENSE and NOTICE `LICENSE` said only that the manifests under `deploy/` *reference* third-party container images. It did not say that several of those manifests and config files are themselves copied from upstream projects. This PR adds a final section listing each copied file with its upstream repository, version and copyright holder, and adjusts the preamble sentence accordingly. `NOTICE` gains the attribution for the two ASF upstreams, Apache Pulsar (rendered chart) and Apache Kvrocks (config file), which Apache-2.0 requires to be propagated. Every upstream was identified by diffing the shipped file against the upstream artefact at the stated tag. **All are Apache-2.0.** | Upstream | Version | File(s) | Match | |---|---|---|---| | cert-manager | v1.10.1 | `deploy/cert-manager/cert-manager.yaml` | identical to release asset | | ingress-nginx | v1.5.1, v1.8.1 | `deploy/ingress-nginx/*.yaml` | upstream `deploy/static/provider/*` with 3–6 lines of local edits | | Kubegres | v1.18 | `deploy/openserverless-permissions/kubegres-crd.yaml` | identical | | Milvus Operator | v1.1.3 | `.../openserverless-milvus-operator-crd.yaml` | rendered chart CRDs, 18 lines of Helm templating differ | | Milvus / milvus-helm | chart 4.2.32 | 4 config maps, `milvus_manifest.yaml`, `milvus-pulsar.yaml` | retains `Copyright (C) 2019-2021 Zilliz` | | MongoDB Community Operator | v0.7.3 | `deploy/mongodb-operator/mongodb-crd.yaml` | identical | | Prometheus community chart | server config | `deploy/monitoring/prometheus-02-cm.yaml` | rendered | | Apache Kvrocks | 2.8.0 | `openserverless/templates/kvrocks-cm.yaml` | `kvrocks.conf` with 16 lines of local edits | Two items get an explanatory sentence in `LICENSE`: the MinIO chart 8.0.17 rendered inside `milvus_manifest.yaml` predates MinIO's AGPL switch and is redistributed by milvus-helm under Apache-2.0 (the AGPL server image is only referenced); and the MongoDB operator repo licenses its source under Apache-2.0 but its Agent binary under a proprietary licence, and only the CRD is included. ## Checks - Apache RAT 0.18 over the repo: `Unapproved: 0`. - Only comment lines were added to `cert-manager.yaml`, above the first document separator. ## Related - apache/openserverless#250 makes the equivalent change to the umbrella repo's top-level `LICENSE`/`NOTICE`, which lists these same files under `oplugins-op/`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
