pjfanning opened a new issue, #264:
URL: https://github.com/apache/openserverless/issues/264
`build/openwhisk/tools/admin/src/main/scala/org/apache/openwhisk/core/cli/Main.scala`
(vendored from Apache OpenWhisk, shipped in the 0.9.0-incubating-RC7 source
release) contains code copied from Scallop, which is MIT-licensed:
```scala
private def printErr(message: String): Unit = {
//Taken from ScallopConf
if (overrideColorOutput.value.getOrElse(System.console() != null)) {
Console.err.println("[\u001b[31m%s\u001b[0m] Error: %s" format
(printedName, message))
} else {
// no colors on output
Console.err.println("[%s] Error: %s" format (printedName, message))
}
}
```
This is the default `errorMessageHandler` from Scallop 3.3.2 (the version
the admin tool depends on),
[`jvm/src/main/scala/org.rogach.scallop/ScallopConf.scala` lines
77-85](https://github.com/scallop/scallop/blob/v3.3.2/jvm/src/main/scala/org.rogach.scallop/ScallopConf.scala#L77-L85),
minus the final `sys.exit(1)`:
```scala
errorMessageHandler = { message =>
if (overrideColorOutput.value.getOrElse(System.console() != null)) {
Console.err.println("[\u001b[31m%s\u001b[0m] Error: %s" format
(printedName, message))
} else {
// no colors on output
Console.err.println("[%s] Error: %s" format (printedName, message))
}
sys.exit(1)
}
```
Scallop is licensed under the MIT License, `Copyright (C) 2012 Platon Pronko
and Chris Hodapp`. MIT is Category A, so it can be included, but the MIT
licence requires its copyright and permission notice to be kept with the copied
code. Currently the file only carries the ASF header, and the top-level
`LICENSE` does not mention Scallop.
Suggested fix, either:
1. Rewrite `printErr` independently (it is a few lines of error printing),
and drop the "Taken from ScallopConf" comment; or
2. Keep it and add a `LICENSE` entry for Scallop (MIT, with its copyright
line and licence text), noting the file it is used in.
The same code is in upstream Apache OpenWhisk
(`tools/admin/src/main/scala/org/apache/openwhisk/core/cli/Main.scala`).
Related: #259, #260.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
