On Thu, Nov 12, 2009 at 4:28 PM, Lars Francke <[email protected]> wrote:
> - As of now the XML is not indented. I use Woodstox[1] for XML output
> and that doesn't have an option to "pretty print" the output. It is
> not a problem for me but if it is requested I can use StaxMate or
> something else to properly indent the XML

i'm pretty sure no-one minds. as you say, anyone who wants it indented
can easily do it with xmllint and friends.

> - Changesets: num_changes from the database isn't dumped in planet.c.
> It is queried from the database but not used anywhere. The data _can_
> be calculated but it isn't that easy if not using the standard db
> schema and not easily done by reading the XML stream. I could just
> dump it too. I haven't had a look at the API if this field is set
> correctly at all?!

it should be set correctly. you're welcome to dump it out on the
changesets if you think it's useful.

> - I'm using the same technique as planet.c in regards to the output of
> the data (just streaming it to standard output), I just assume that
> this is okay? Are there any other things I'll have to change in
> comparison to the way planet.c works?

yeah. the output will be piped directly into pbzip2, most probably.

cheers,

matt

_______________________________________________
dev mailing list
[email protected]
http://lists.openstreetmap.org/listinfo/dev

Reply via email to