On Wed, Apr 6, 2011 at 11:36 AM, NopMap <[email protected]> wrote: > > Mike Collinson wrote on dev: > "... the License Working Group intends implementing Phase 3 of the > license change implementation plan [1]. This involves blocking edits > with HTTP "Forbidden" messages until the individual contributor has > Accepted/Declined the new terms" > > Is Potlatch already equipped to handle this reasonably?
Not particularly. For third-party installations, like yours, people are likely to encounter it in two ways 1) The first time they use the third-party p2 2) They've used it before, and are trying to save again In the first case, they won't be able to log in when they try to grant OAuth permissions, so that's reasonable and will be well explained there. For the second case I expect they'll encounter problems when the Connection tries to create a changeset - when this errors it triggers SaveDialog.changesetError which simply shows the test "Error creating changeset" with no further explanation. We would need to undertake work to handle this better i.e. figure out why the changeset has failed, pass the message to the user etc. On a related note it's possible, under different circumstances[1], to get stuck entirely, since if your flash cookies contains OAuth paramaters that the server rejects, you see this message too and there's no way to sort it out short of flushing your flash cookies (which is pretty obscure). We should consider invalidating stored credentials when they aren't accepted. Cheers, Andy [1] This happens easily if the binary has pointed to a different server (e.g. a test server) or if you revoke permissions via the website. _______________________________________________ Potlatch-dev mailing list [email protected] http://lists.openstreetmap.org/listinfo/potlatch-dev
