On Feb 6, 2011, at 9:47 AM, Ben Pfaff wrote: > On Sun, Feb 06, 2011 at 01:32:22AM -0800, Justin Pettit wrote: >> The XenServer init script makes a backup before converting the OVSDB >> database file. This may be useful for debugging, so do the same on >> Debian. Also, store the schema version in the database. > > Did you test this? The bash online help for the "local" keyword (from > "help local") says: > > Local variables can only be used within a function; they are visible > only to the function where they are defined and its children. > > but your use of local is not within a function.
Yes, I tested this, and it does work fine even outside of functions (I just tested it with a simple script). However, it's clearly not correct, so I removed the "local" designations. > It looks otherwise reasonable to me. With that change, I went ahead and pushed. Thanks for the review! --Justin _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
