On Mon, Feb 07, 2011 at 12:26:04PM -0800, Jesse Gross wrote: > On Mon, Feb 7, 2011 at 10:46 AM, Ben Pfaff <[email protected]> wrote: > > On Sat, Feb 05, 2011 at 04:14:47PM -0800, Jesse Gross wrote: > >> Using the kernel vlan acceleration has a number of benefits: > >> it enables hardware tagging, allows usage of TSO and checksum > >> offloading, and is generally easier to manipulate. ?This switches > >> the vlan actions to use skb->vlan_tci field for any necessary > >> changes. ?In places that do not support vlan acceleration in a way > >> that we can use (in particular kernels before 2.6.37) we perform > >> any necessary conversions, such as tagging and GSO before the > >> packet leaves Open vSwitch. > >> > >> Signed-off-by: Jesse Gross <[email protected]> > > > > I examined the changes in this patch pretty carefully, but I didn't do a > > big-picture pass over the code to look for places that might have been > > missed. ?Let me know if you'd like me to do that too. > > I'm not too worried about missed places as there are only a few > locations where vlan tags matter: ingress, egress, and tag > manipulations. So certainly go ahead if you want but I'm not sure > that it's strictly necessary.
OK, I'm going to skip it then. All your responses look fine to me. I think I gave you this already but just in case: Acked-by: Ben Pfaff <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
