Thanks for writing this up.
In the manpage, lib/vconn-active.man lists ways to connect to OpenFlow
switches or controllers. Instead, we should list ways to connect to
OSVDB clients, which are listed in ovsdb/remote-passive.man and
ovsdb/remote-active.man.
I'd be a little more explicit about what the managers commands do.
Maybe something like this:
These commands manipulate the \fBmanagers\fR and
\fBmanager_options\fR columns in the \fBOpen_vSwitch\fR table and
rows in the \fBManagers\fR table. When \fBovsdb\-server\fR is
configured to use those rows and columns for OVSDB connections, as
described in \fBINSTALL.Linux\fR and in the startup scripts provided
with Open vSwitch, this allows the administrator to use
\fBovs\-vsctl\fR to configure database connections.
>From pre_manager(), I would not call pre_get_info(). It should not be
necessary, because none of the manager operations call get_info().
In cmd_get_manager() I would use svec_sort_unique(), instead of
svec_sort(), because it is valid for a manager to appear in both places
and in such a case we only want to print it once.
In delete_managers(), I would only delete the rows in the Managers table
that the manager_options column referred to, instead of all the rows.
In insert_managers(), I would also put each manager in the 'managers'
column of Open_vSwitch, for compatibility with any software that expects
the list of managers to appear there.
I suggest adding a test to tests/ovs-vsctl.at. You can follow the form
of the "controllers" test that is already there.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
