Either one sounds fine to me. Maybe special_cb since "control path" is OpenFlow terminology for something else.
On Mon, Feb 07, 2011 at 01:52:34PM -0800, Ethan Jackson wrote: > How about control_cb as in shove it up to the control path (bridge). > Or perhaps special_cb as in handle special packets. > > Ethan > > On Mon, Feb 7, 2011 at 1:32 PM, Ben Pfaff <[email protected]> wrote: > > On Fri, Feb 04, 2011 at 03:02:37PM -0800, Ethan Jackson wrote: > >> Before this patch, special packets such as LACP and CFM messages > >> were only processed if they had NORMAL open flow actions. ?With > >> this patch these messages are always processed unless originated in > >> ofproto_send_packet(). > > > > It looks fine, but is "admissible" the right term? ?We already have a > > use of that term through the function is_admissible() in bridge.c. ?This > > commit introduces a new and (I think) quite different meaning of that > > word. ?I'd rather use a different word or phrase to avoid confusion. > > > > Otherwise I'm happy with this. ?Thank you! > > > > _______________________________________________ > > dev mailing list > > [email protected] > > http://openvswitch.org/mailman/listinfo/dev_openvswitch.org > > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
