On Feb 7, 2011, at 3:35 PM, Jesse Gross wrote: > On Mon, Feb 7, 2011 at 3:13 PM, Justin Pettit <[email protected]> wrote: >> Both userspace and the kernel allocate space based on the max size of a >> nlattr-formatted flow. It was easy to change the max size of a flow >> definition and cause crashes by forgetting to update one or both of >> those definitions. This commit attempts to make that harder by >> providing a better description of how the max size is calculated and >> defining that size in datapath-protocol.h and have the others use it. > > This commit message is slightly out of date because it describes the > changes to datapath-protocol.h. > > I get some whitespace errors: > Applying: datapath: Better calculate max nlattr-formatted flow size. > /home/jesse/openvswitch/.git/rebase-apply/patch:38: trailing whitespace. > * ODP_KEY_ATTR_TUN_ID 8 -- 4 12 > /home/jesse/openvswitch/.git/rebase-apply/patch:43: trailing whitespace. > * ODP_KEY_ATTR_IPV6 34 2 4 40 > /home/jesse/openvswitch/.git/rebase-apply/patch:67: trailing whitespace. > * ODP_KEY_ATTR_TUN_ID 8 -- 4 12 > /home/jesse/openvswitch/.git/rebase-apply/patch:72: trailing whitespace. > * ODP_KEY_ATTR_IPV6 34 2 4 40 > warning: 4 lines add whitespace errors. > > Otherwise though: > Acked-by: Jesse Gross <[email protected]>
Thanks. I fixed those up and pushed. --Justin _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
