On Mon, Feb 7, 2011 at 4:11 PM, Ben Pfaff <[email protected]> wrote: > On Mon, Feb 07, 2011 at 04:01:07PM -0800, Jesse Gross wrote: >> vlan_deaccel_tag() was introduced to move a vlan tag from skb->vlan_tci >> to the packet but there was still an open coded varient when doing >> an upcall. >> >> Signed-off-by: Jesse Gross <[email protected]> > > This message presents this as a change without any difference in > behavior, but the code being deleted does not zero the skb's vlan_tci > whereas vlan_deaccel_tag() does.
Clearing skb->vlan_tci makes no difference here because the skb is freed shortly afterwards and nothing in between reads vlan_tci. Regardless, clearing it is probably the more correct thing to do anyways. I added a note to the commit message. > > Assuming that's intentional: > > Acked-by: Ben Pfaff <[email protected]> Thanks, I pushed both of these. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
