On 2/14/11 1:33 PM, Ben Pfaff wrote: > A comment you added refers to a commit by number only. It's better to > add the first line of the commit message, too, e.g.: > # Bug #4667: one-time cleanup of brctl removal in commit 54f16a10 > # (xenserver: Remove brctl wrapper script).
Ok, done. > In place of > if readlink /usr/sbin/brctl -q >/dev/null && > I would write > if test -h /usr/sbin/brctl && Done, except I used '[' instead of test, like other parts of the spec file do. > Otherwise this looks good to me. I assume that you've tested the > installation, upgrade, and removal cases. Thank you. Yes, I have tested those cases. Thanks for your review. I've pushed this. -Andrew _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
