On 2/14/11 9:54 AM, Ben Pfaff wrote: > We should add a license header to the new XML and shell scripts. It's > annoying for trivial stuff, but when we don't do it people ask what > the license is. (That even happened for a 1-line script!)
Ok, both are done. > I'd suggest that they should have the same license as xen-bugtool: > Then you'll need to add those files to the list for LGPL 2.1 in > debian/copyright.in. Whoops, missed that. Will commit that separately. > You could avoid the basename call in the script by writing the loop > as > for iface in `cd /sys/class/net && echo *`; do Ok, did that. > Would you mind writing /sbin/tc explicitly? When I tested this script > the lack of /sbin in my $PATH was the only thing that prevented me > from running it as an ordinary user. Sure, changed. > Thank you! Thanks for your review. I pushed this. -Andrew _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
