Here are a few fixes related to issues raised from our first run through
Coverity*. They are mostly ones that struck me as serious or required
only trivial fixes. Another, more thorough pass will need to be done.
These have only been compile-tested and run through "make check".
--Justin
* This only represents user-space, since we haven't checked the kernel
module yet.
Justin Pettit (14):
ovsdb: Fix double free in ovsdb_file_open_log().
leak-checker: Fix warning about use after free in hook_free().
ovs-brcompatd: Fix memory leak in handle_fdb_query_cmd().
ofproto: Free "controller_name" in ofconn_run().
discovery: Free "buffer" in discovery_set_accept_controller_re().
ovsdb-data: Free string leaked in ovsdb_datum_from_string().
daemon: Fix leak of string in make_pidfile().
ovsdb: Free "error" string in ovsdb_execute_insert().
socket-util: Free strings in make_sockaddr_un() error handling.
netdev-linux: Use ovs_strlcpy() instead of improper strncpy().
lib: Replace remaining unsafe strncpy()s with ovs_strlcpy().
ovsdb: Don't check "date" before assignment in
ovsdb_file_txn_from_json().
ovs-vsctl: Check "key" is valid before dereferencing in
get_external_id().
vconn: Fix comparison that should be assignment in
vconn_open_block().
lib/daemon.c | 2 +-
lib/leak-checker.c | 2 +-
lib/netdev-linux.c | 16 ++++++++--------
lib/ofp-print.c | 2 +-
lib/ovsdb-data.c | 4 +++-
lib/route-table.c | 4 ++--
lib/socket-util.c | 4 +++-
lib/vconn.c | 2 +-
ofproto/discovery.c | 1 +
ofproto/ofproto.c | 1 +
ovsdb/execution.c | 1 +
ovsdb/file.c | 5 +----
utilities/ovs-vsctl.c | 2 +-
vswitchd/ovs-brcompatd.c | 1 +
14 files changed, 26 insertions(+), 21 deletions(-)
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
