On 03/11/11 22:13, Justin Pettit wrote:
doesn't actually know whether IPsec will actually work. With this
I think this reads better with the first 'actually' omitted.
Bug #4854
I think there should be a period at the end of the line.
+ if (pid<0 || kill(pid, 0)) {
Shouldn't there be spaces around the < operator?
+ VLOG_WARN("%s: ovs-monitor-ipsec doesn't appear to be running, "
+ "traffic may not pass", name);
This check can be fooled by PID wrapping. It might be better to have
ovs-monitor-ipsec flock(2) its PID file and for netdev-vport to check
that the file is locked, since the lock will be released even if the
process crashes. Or maybe it's not worth worrying about. What do you think?
-Andrew
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
