On Fri, Mar 11, 2011 at 07:15:45PM -0800, Andrew Evans wrote: > Only the time connected (if connected) or disconnected (if disconnected) is > currently reported for each manager. Change to reporting both in seconds since > the last connect and disconnect events respectively. An empty value indicates > no previous connection or disconnection. > > This can help diagnose certain connectivity problems, e.g. flapping. > > Requested-by: Peter Balland <[email protected]> > Bug #4833.
Thanks for so patiently refining this. I have only a few comments. I think that the function-level comment on reconnect_get_last_connect_elapsed() is incorrect: if 'fsm' connected, then the number of milliseconds since 'fsm' was last connected is 0, but this function won't necessarily return that. Maybe "the number of milliseconds since 'fsm' last successfully connected to its peer" or something else that indicates that it's the edge disconnected -> connected that we're tracking? Same feedback for reconnect_get_last_disconnect_elapsed(). In update_remote_row(), I would have expected the key/value pairs for sec_since_connect and sec_since_disconnect to be omitted entirely, instead of being set to empty values, if there have been no connections or disconnections. Did you carefully look through the updated test results to make sure that they make sense? I did for an earlier version of this patch, but I didn't yet for this version. If you haven't, let me know, and I will. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
