On Fri, Mar 11, 2011 at 03:41:03PM -0800, Ethan Jackson wrote: > The source of truth for QoS statistics on a given interface is tc. > Unfortunately, output from tc can be a little bit confusing and > does not follow the same data model as OVS. This commit adds a > "qos/show" appctl command which gives friendlier output.
Thanks for writing this up. I bet that it will be useful from time to time. In qos_unixctl_show(), the message "QoS not on configured" could be improved. Also, "!strlen(type)" could be better written "*type == '\0'". It would be nice to report the error returned from netdev_dump_stats() or netdev_get_queue_stats() if they return nonzero. qos_unixctl_show_cb() uses a mixture of spaces and tabs for indentation in its output. It would probably be better to stick to one or the other. In qos_unixctl_show_cb(), it looks like missing (UINT64_MAX) queue stats will be printed as 18446744073709551615. It would probably be better to print them some more user-friendly way. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
