Sounds good.

Ethan

On Mon, Mar 14, 2011 at 4:40 PM, Ben Pfaff <[email protected]> wrote:
> Thank you.  I pushed these two patches and the following too after
> seeing "make distcheck -j4" die due to the problem that it fixes:
>
> --8<--------------------------cut here-------------------------->8--
>
> From: Ben Pfaff <[email protected]>
> Date: Mon, 14 Mar 2011 16:39:28 -0700
> Subject: [PATCH] ovsdbmonitor: Fix "make install" race.
>
> In a parallel make, the install-exec-local target runs concurrently with
> the creation of the directory that it installs into.  Fix the race by
> using the install-exec-hook target instead, which runs subsequently to
> directory creation.
> ---
>  ovsdb/ovsdbmonitor/automake.mk |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ovsdb/ovsdbmonitor/automake.mk b/ovsdb/ovsdbmonitor/automake.mk
> index e24c536..11c25cb 100644
> --- a/ovsdb/ovsdbmonitor/automake.mk
> +++ b/ovsdb/ovsdbmonitor/automake.mk
> @@ -31,7 +31,7 @@ ovsdbmonitordir = ${pkgdatadir}/ovsdbmonitor
>  if BUILD_OVSDBMONITOR
>  noinst_SCRIPTS += ovsdb/ovsdbmonitor/ovsdbmonitor
>  ovsdbmonitor_DATA = $(ovsdbmonitor_pyfiles)
> -install-exec-local:
> +install-exec-hook:
>        sed -e '/NOINSTALL/d' < ovsdb/ovsdbmonitor/ovsdbmonitor > 
> ovsdb/ovsdbmonitor/ovsdbmonitor.tmp
>        chmod +x ovsdb/ovsdbmonitor/ovsdbmonitor.tmp
>        $(INSTALL_PROGRAM) ovsdb/ovsdbmonitor/ovsdbmonitor.tmp 
> $(DESTDIR)$(bindir)/ovsdbmonitor
> --
> 1.7.1
>
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to