Thank you for the review.  I pushed just this one since it is a bug
fix.

On Mon, Mar 21, 2011 at 11:09:04AM -0700, Ethan Jackson wrote:
> Good catch.  Looks Good.
> 
> On Mon, Mar 21, 2011 at 10:59 AM, Ben Pfaff <[email protected]> wrote:
> > This code was checking a name from cfg->interfaces[i] but using the result
> > to decide whether to delete port->ifaces[i]. ?The two arrays aren't
> > necessarily in the same order so this code could delete the wrong iface.
> >
> > Found by inspection. ?This is probably not a common problem in practice
> > because I imagine that deleting an interface from a bond, without deleting
> > the bond itself, is a rare operation. ?The problem would also be
> > intermittent--after a few switch reconfiguration cycles I imagine that
> > the problem would resolve.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to