On Tue, Mar 22, 2011 at 05:39:29PM -0700, Jesse Gross wrote: > On Tue, Mar 22, 2011 at 5:18 PM, Ben Pfaff <[email protected]> wrote: > > +/** > > + * DOC: VLAN tag manipulation. > > + * > > + * &struct sk_buff handling of VLAN tags has evolved over time: > > + * > > + * In 2.6.26 and earlier, VLAN tags were always represented as a raw 802.1Q > > + * header inside the skb data. > > This isn't strictly true: vlan acceleration actually existed long > before 2.6.27. However, on receive the drivers called directly into > the vlan device code and on transmit it was stored in a vlan skb->cb. > Receive is the interesting one for us and we have no chance to get the > tag on these kernels, which is why our code assumes it doesn't exist.
I should have known that, or guessed it. I corrected the comment: * In 2.6.26 and earlier, VLAN tags did not have any generic representation in * an skb, other than as a raw 802.1Q header inside the packet data. > Otherwise looks good. > Acked-by: Jesse Gross <[email protected]> Thank you, I added your ack and pushed this. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
