Good catch. Makes sense to me.
--Justin
On Mar 29, 2011, at 10:08 AM, Ben Pfaff wrote:
> The test ofproto_has_primary_controller() is meaningless, since OFPP_NORMAL
> can cause the MAC learning table and port bonding to be in use even when
> there is a controller.
>
> I see that this bug has been here since early 2009, when the OFPP_NORMAL
> feature was introduced in the bridge. (Obviously it's not a severe
> problem.)
> ---
> vswitchd/bridge.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 9660aef..bf89778 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -1464,12 +1464,7 @@ bridge_wait(void)
> struct port *port;
>
> ofproto_wait(br->ofproto);
> - if (ofproto_has_primary_controller(br->ofproto)) {
> - continue;
> - }
> -
> mac_learning_wait(br->ml);
> -
> HMAP_FOR_EACH (port, hmap_node, &br->ports) {
> port_wait(port);
> }
> --
> 1.7.1
>
> _______________________________________________
> dev mailing list
> [email protected]
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
