Looks Good.
On Mon, Mar 28, 2011 at 1:19 PM, Ben Pfaff <[email protected]> wrote: > "urgent" probably overstates the case. It would have prevented the > problems that you fixed with your commit that makes remote_mps > persistent, but now that it's persistent anyway it will only prevent > that kind of thing from recurrring. > > On Mon, Mar 28, 2011 at 01:15:16PM -0700, Ethan Jackson wrote: >> Is this series urgent? I can put it at the top of my review queue. >> >> Ethan >> >> On Mon, Mar 28, 2011 at 1:07 PM, Ben Pfaff <[email protected]> wrote: >> > This function only worked properly inside OVSDB itself, because that is >> > the only place where the 'refTable' member of ovsdb_base_type is set. >> > Both inside and outside OVSDB, 'refTableName' is set for reference types, >> > so it's better to check for that. >> > >> > This doesn't fix any existing bug because this function was only used >> > inside OVSDB until now. >> > --- >> > ?lib/ovsdb-types.h | ? ?4 ++-- >> > ?1 files changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/lib/ovsdb-types.h b/lib/ovsdb-types.h >> > index 6903aa8..e852391 100644 >> > --- a/lib/ovsdb-types.h >> > +++ b/lib/ovsdb-types.h >> > @@ -1,4 +1,4 @@ >> > -/* Copyright (c) 2009, 2010 Nicira Networks >> > +/* Copyright (c) 2009, 2010, 2011 Nicira Networks >> > ?* >> > ?* Licensed under the Apache License, Version 2.0 (the "License"); >> > ?* you may not use this file except in compliance with the License. >> > @@ -174,7 +174,7 @@ ovsdb_atomic_type_is_valid(enum ovsdb_atomic_type >> > atomic_type) >> > ?static inline bool >> > ?ovsdb_base_type_is_ref(const struct ovsdb_base_type *base) >> > ?{ >> > - ? ?return base->type == OVSDB_TYPE_UUID && base->u.uuid.refTable; >> > + ? ?return base->type == OVSDB_TYPE_UUID && base->u.uuid.refTableName; >> > ?} >> > >> > ?static inline bool >> > -- >> > 1.7.1 >> > >> > _______________________________________________ >> > dev mailing list >> > [email protected] >> > http://openvswitch.org/mailman/listinfo/dev >> > > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
