On Wed, Apr 13, 2011 at 01:58:24PM -0700, Ethan Jackson wrote:
> When all flows in a bond are revalidated, stale bond_entry's can
> cause incorrect load balancing.  These issues will naturally
> resolve themselves overtime.  However, it's better to deal with
> them immediately.

My only complaints are cosmetic.

There's a blank line before the first line of code in
bond_entry_reset().

Also in bond_entry_reset(), would you mind putting the assignment to
bond->next_rebalance after the memset?  Then all of the code that
deals with the hash is grouped together.

Thanks,

Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to