On May 11, 2011, at 9:17 AM, Ben Pfaff wrote: > On Wed, May 11, 2011 at 12:40:59AM -0700, Justin Pettit wrote: >> Commit daf2ebb (xenserver: Use xe-switch-network-stack in RPM spec >> file.) changed the spec file to use xe-switch-network-backend instead of >> directly modifying "/etc/xensource/network.conf". It incorrectly >> assumed that the command was in the search path. It also didn't take >> into account that the command will remove the "openvswitch" service with >> chkconfig. This commit fixes those errors. >> >> (For consistency, xe-switch-network-backend should also remove >> "openvswitch-xapi-update" service. I will file an issue with the >> XenServer guys about that.) > > The commit message needs a Signed-off-by line. > > You could just add "exit 0" at the end of the scriplet, with an > appropriate comment, instead of the dance with moving stuff around. > That would avoid the need to worry about ordering in the future.
Good suggestion. I'm testing that now and will send out a new version shortly. --Justin _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
