On Thu, May 26, 2011 at 03:27:49PM -0700, Ethan Jackson wrote:
> This new function will provide a much simpler replacement for
> netdev_monitor in the future.
I'd use unsigned int, instead of plain int, since the wraparound
properties of unsigned ints are well defined (whereas INT_MAX + 1 is
undefined).
Why is the value 0 special?
I'd add to the comments the kinds of changes that should change the
sequence number.
The comment in netdev-provider.h should be addressed to the
implementor of the network device, not the caller of
netdev_change_seq(). So it would be phrased more like this:
Returns a nonzero sequence number which indicates changes in one
of 'netdev''s properties. The returned sequence number must
change if 'netdev' has changed. It is allowed to change even if
'netdev' has not changed, although implementations should try to
avoid this.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
