On Wed, Jun 1, 2011 at 13:47, Ben Pfaff <[email protected]> wrote: > On Wed, Jun 01, 2011 at 01:11:39PM -0700, Ethan Jackson wrote: >> collect_rules_loose() and collect_rules_strict() pass a uint16_t >> out_port into rule_has_out_port() which expects a ovs_be16. > > Please look again. This commit also changes rule_has_out_port() to > expect a uint16_t.
Ooops, I verified it using ctags which pointed me to a different repository. My bad. Looks Good. Ethan > >> > + ? ?error = collect_rules_loose(p, fm->table_id, &fm->cr, fm->out_port, >> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&rules); >> > + ? ?return (error ? error >> > + ? ? ? ? ? ?: !list_is_empty(&rules) ? delete_flows__(&rules) >> > + ? ? ? ? ? ?: 0); >> > ?} >> >> The check for list_is_empty() here seems redundant to me. I suppose >> it's fine as documentation though. > > OK, thanks. In the next patch it will at least avoid some unnecessary > work when the list is empty. > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
