On Wed, Jun 22, 2011 at 02:18:49PM -0700, Ethan Jackson wrote:
> Commit 400430 "xenserver: Give tap devices iface-ids." copies the
> iface-id from vifs to their related tap device. It turns out this
> is not sufficient, so this commit copies all relevant external_ids
> over.
>
> Requested-by: Pankaj Thakkar <[email protected]>
> Signed-off-by: Ethan Jackson <[email protected]>
>
> Bug #5954.
Reid already made a lot of useful comments. I have one more:
> +def update_tap_from_vif(idl, tap_name, vif_name):
> + ifaces = idl.data["Interface"]
> + tap = None
> + vif = None
> +
> + for i in ifaces:
> + name = str(ifaces[i].name).strip('"')
This seems needlessly indirect. Will ifaces[i].as_scalar() do the
same thing?
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
