On Fri, Jun 24, 2011 at 9:09 AM, Ben Pfaff <[email protected]> wrote: > On Thu, Jun 23, 2011 at 05:24:39PM -0700, Jesse Gross wrote: >> The linux-2.6 and compat-2.6 directories apply equally to the upcoming >> Linux 3.0 release, so this drops the 2.6 suffix and updates Makefiles. >> >> Signed-off-by: Jesse Gross <[email protected]> > > I see a few nits. > > git-am reports one line with trailing whitespace. > > The "/linux-2.6" line in datapath/linux/.gitignore seems like it could > be deleted. I don't know why it was there to start with. Justin > added it in commit 757c13 in 2009, so maybe he knows. > > grep found some straggling linux-2.6 references that need to be fixed > up: > > debian/rules.modules:30: cd openvswitch && $(MAKE) -C > datapath/linux-2.6 > debian/rules.modules:32: install -m644 > openvswitch/datapath/linux-2.6/*_mod.ko $(DSTDIR)/ > rhel/openvswitch-kmod-rhel5.spec.in:67: %{__make} -C datapath/linux-2.6 > %{?_smp_mflags} > rhel/openvswitch-kmod-rhel5.spec.in:77: %{__make} -C "${KSRC}" > modules_install M=$PWD/_kmod_build_$kvariant/datapath/linux-2.6 > rhel/openvswitch-kmod-rhel6.spec.in:44: %{__make} -C > _$flavor/datapath/linux-2.6 %{?_smp_mflags} > rhel/openvswitch-kmod-rhel6.spec.in:52: > M=$PWD/_$flavor/datapath/linux-2.6 > xenserver/openvswitch-xen.spec:119:find datapath/linux-2.6 -name *.ko -exec > install -m 755 \{\} > $RPM_BUILD_ROOT/lib/modules/%{xen_version}/extra/openvswitch \; > > It might be kind to mention the renaming in ChangeLog, since users may > have packaging scripts that use this directory name. > > With those comments: > > Acked-by: Ben Pfaff <[email protected]>
Thanks, I made these changes and pushed. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
