I should have seen it in review. Thanks for the reviews, I pushed both of these.
On Tue, Jul 19, 2011 at 01:31:11PM -0700, Ethan Jackson wrote: > Oops, surprised I missed that. Thanks, looks good. > > Ethan > > On Tue, Jul 19, 2011 at 09:17, Ben Pfaff <[email protected]> wrote: > > This field was overlooked in commit b3e9b2eda9a "ofproto: Optimize datapath > > actions." > > > > Found by inspection. > > --- > > ?ofproto/ofproto-dpif.c | ? ?5 +++++ > > ?1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > > index 6c0f0b8..dd5d1aa 100644 > > --- a/ofproto/ofproto-dpif.c > > +++ b/ofproto/ofproto-dpif.c > > @@ -2788,6 +2788,11 @@ commit_odp_actions(struct action_xlate_ctx *ctx) > > ? ? ? ? base->nw_dst = flow->nw_dst; > > ? ? } > > > > + ? ?if (base->nw_tos != flow->nw_tos) { > > + ? ? ? ?nl_msg_put_u8(odp_actions, ODP_ACTION_ATTR_SET_NW_TOS, > > flow->nw_tos); > > + ? ? ? ?base->nw_tos = flow->nw_tos; > > + ? ?} > > + > > ? ? if (base->vlan_tci != flow->vlan_tci) { > > ? ? ? ? if (!(flow->vlan_tci & htons(VLAN_CFI))) { > > ? ? ? ? ? ? nl_msg_put_flag(odp_actions, ODP_ACTION_ATTR_STRIP_VLAN); > > -- > > 1.7.4.4 > > > > _______________________________________________ > > dev mailing list > > [email protected] > > http://openvswitch.org/mailman/listinfo/dev > > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
