It's a little more general than it looks, in that if you give it a connection method that contains ':', you will still get appropriate error messages for that case.
Thanks for the review, I'll push this soon. On Thu, Jul 21, 2011 at 01:23:43AM -0700, Justin Pettit wrote: > It's a bit narrow in that other methods are supported, but they > probably cover the most common ways ovs-ofctl is called. > > --Justin > > > On Jul 20, 2011, at 2:32 PM, Ben Pfaff wrote: > > > Suggested-by: Peter Balland <[email protected]> > > --- > > utilities/ovs-ofctl.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c > > index f7e1400..4f81334 100644 > > --- a/utilities/ovs-ofctl.c > > +++ b/utilities/ovs-ofctl.c > > @@ -258,7 +258,7 @@ open_vconn__(const char *name, const char > > *default_suffix, > > } > > open_vconn_socket(socket_name, vconnp); > > } else { > > - ovs_fatal(0, "%s is not a valid connection method", name); > > + ovs_fatal(0, "%s is not a bridge or a socket", name); > > } > > > > free(bridge_path); > > -- > > 1.7.4.4 > > > > _______________________________________________ > > dev mailing list > > [email protected] > > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
