On Thu, Jul 21, 2011 at 06:18:01PM -0700, Ethan Jackson wrote: > The mac-learning code predates the hmap data structure in OVS. For > this reason, it rolled it's own hmap-like bucket concept. This > patch converts it to use an hmap which makes the code slightly > simpler and easier to understand.
Looks good. Thank you! We could get rid of the free list and the fixed array of mac_entries, replacing them by malloc() and free() and using hmap_count() to limit the number of entries. (When I wrote this code I had a notion that we might want to avoid malloc() entirely in OVS, at least after startup. I don't think that we're going to go that direction though.) _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
