Nifty! I like this patch.
> - if (argc != 1) {
> + switch (argc) {
> + case 0:
> + return xasprintf("unix:%s/db.sock", ovs_rundir());
> +
> + case 1:
> + return argv[0];
> +
> + default:
> VLOG_FATAL("database socket is only non-option argument; "
> "use --help for usage");
> }
I'll make the same comment here that I did in the previous patch about
xstrdup-ing argv[0]. Also I think the VLOG_FATAL message needs to be
updated.
Otherwise looks good,
Ethan
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
