On Mon, Jul 25, 2011 at 01:33:35PM -0700, Ethan Jackson wrote:
> > ?ro_c = echo '/* -*- mode: c; buffer-read-only: t -*- */'
> > +ro_shell = printf '\043 Generated automatically -- do not modify! ? ?-*- 
> > buffer-read-only: t -*-\n'
> 
> Trailing whitespace on this line.

Oops, removed.

> > ?$(srcdir)/rhel/openvswitch.spec: rhel/openvswitch.spec.in 
> > $(top_builddir)/config.status
> > ? ? ? ?sed -e 's,[@]VERSION[@],$(VERSION),g' < $< > $@
> > + ? ? ? ($(ro_shell) && sed -e 's,[@]VERSION[@],$(VERSION),g') \
> > + ? ? ? ? ? ? ? < $(srcdir)/rhel/openvswitch.spec.in > $@
> 
> I may be misunderstanding, but I would think you want to delete the
> old sed in this rule.

Oops, you're right.

> Otherwise looks good.

Thanks, I'll fix that stuff up and push soon.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to