>> This patch fixes the issue by disallowing the creation of netdevs >> with unsupported configuration options. > > Currently in netdev-vport.c:parse_tunnel_config() we just warn if > there is an unknown option. I think if we simply returned an error at > that point it would have the same effect and we wouldn't need to > duplicate the logic for valid options.
That would work in most cases. It doesn't work in the case where a tunnel is created with proper configuration options, and then an invalid configuration option is added. You run into the same problem because netdev_open() checks if the configuration is equal before attempting to open the netdev. I'd be curious what Ben's opinion is. I think the real problem here may be with the structure of netdev_open(). Perhaps we should always be opening the new netdev and replacing the old one with it. I'll have to think about it. Ethan _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
