On Tue, Sep 06, 2011 at 09:35:48AM +0900, Simon Horman wrote: > When starting openvswtich-vswitch fail gracefully if > modules can't be loaded. Otherwise package install will > fail if the openvswitch_mod modules is not available. > > This resolves a regression between 1.1.1 and 1.2.1. > > This makes use of the load-kmod subcommand which was > added to ovs-ctl for this purpose.
"if !" isn't entirely portable (and the Autoconf manual also mentions that some shells have bugs in this area), so I try to avoid it in OVS shell scripts. I guess that openvswitch-switch.init will only be used on GNU/Linux, so that the buggy shells won't be encountered in practice, but still I prefer to make it easier to cut and paste among shell scripts. Would you mind modifying the patch to avoid "if !"? Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
