On Thu, Sep 08, 2011 at 01:11:07PM -0700, Ben Pfaff wrote: > On Wed, Sep 07, 2011 at 10:10:31AM +0900, Simon Horman wrote: > > When starting openvswtich-vswitch fail gracefully if > > modules can't be loaded. Otherwise package install will > > fail if the openvswitch_mod modules is not available. > > > > This resolves a regression between 1.1.1 and 1.2.1. > > > > This makes use of the load-kmod subcommand which was > > added to ovs-ctl for this purpose. > > I was ready to push this patch to master when I noticed a nit. > > It makes sense not to fail package installation if the kernel module > isn't available, but it probably doesn't make sense to allow > "/etc/init.d/openvswitch start" to always return success in such a > case. > > What if we modified the patch to instead add a new load-kmod target to > /etc/init.d/openvswitch-switch, that does what you added to the start > function below, and then separately add > > # Do not fail package installation just because the kernel module > # is not available. > if [ -x /etc/init.d/openvswitch-switch ]; then > invoke-rc.d openvswitch-switch load-kmod || exit 0 > fi > > to debian/openvswitch-switch.postinst. > > Does that make sense? I think then we get the effect that we really > want.
Hi Ben, yes, I think that might work well. I'll give it a spin and send some updated patches. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
