On Thu, Sep 08, 2011 at 06:59:52PM -0700, Ethan Jackson wrote: > 802.1ag only allows for MPIDs in the range [1, 8191]. This is > restrictive enough to make assignment of MPIDs to instances of OVS > awkward. This patch allows six byte MPIDs when running in extended > mode.
s/six/eight/ above. I'd be tempted to say that mpids must be in either range [1, 8191] or [UINT16_MAX + 1, UINT64_MAX], which would allow cfm_is_valid_mpid() to be valid even for extended mpids, but I'll leave that up to you. When extended mode is enabled, the "normal" mpid is generated with a hash, but I don't see anything that ensures that the hash value is in the range [1, 8191]. Looks good otherwise, and much nicer than the version that used 6-byte MPIDs. Thank you. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
