On Thu, Sep 15, 2011 at 04:18:06PM -0700, Jesse Gross wrote:
> On Tue, Sep 13, 2011 at 6:11 PM, Pravin Shelar <[email protected]> wrote:
> > Fixed according to comments from Jesse.
> >
> > ------
> > Currently ovs is using device stats for Linux devices and count them
> > itself in other situations. This leads to overlap with hardware stats,
> > inconsistencies, etc. It's much better to just always count the packets
> > flowing through the switch and let userspace do any merging that it wants.
> >
> > Following patch removes vport->get_stats() interface. vport-stat is changed
> > to use new `struct ovs_vport_stat` rather than rtnl_link_stats64.
> > Definitions
> > of rtnl_link_stats64 is removed from OVS.
> >
> > Signed-off-by: Pravin B Shelar <[email protected]>
>
> The normal way to format this commit message is have the lower portion
> be the actual commit message and then any messages such as "Fixed..."
> at the bottom separated by three dashes so that it won't go into the
> permanent commit log. Once this is pushed, nobody will care about the
> previous iterations that didn't make it in.
FWIW, this format has always made me a bit uncomfortable too--it often
seems weirdly out-of-order--so that's why I often use the alternate
format that was introduced in newer versions of Git, described in
git-mailinfo(1):
--scissors
Remove everything in body before a scissors line. A line that
mainly consists of scissors (either ">8" or "8<") and perforation
(dash "-") marks is called a scissors line, and is used to request
the reader to cut the message at that line. If such a line appears
in the body of the message before the patch, everything before it
(including the scissors line itself) is ignored when this option is
used.
This is useful if you want to begin your message in a discussion
thread with comments and suggestions on the message you are
responding to, and to conclude it with a patch submission,
separating the discussion and the beginning of the proposed commit
log message with a scissors line.
This can enabled by default with the configuration option
mailinfo.scissors.
I don't know of a disadvantage to enabling mailinfo.scissors.
Here's the scissors line that I use:
--8<--------------------------cut here-------------------------->8--
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
