On Thu, Sep 22, 2011 at 12:29 PM, Justin Pettit <[email protected]> wrote: > On Sep 22, 2011, at 11:17 AM, Jesse Gross wrote: > >> On Wed, Sep 21, 2011 at 11:51 PM, Justin Pettit <[email protected]> wrote: >>> Commit d6b37e42 (datapath: Allow a packet with no input port to omit >>> ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 18886b6 in the >>> "master" branch, but dropped a few lines. This causes a compiler >>> warning about an unused "done" label. This commit brings the two >>> patches in line. >>> >>> Signed-off-by: Justin Pettit <[email protected]> >> >> I thought about this before but decided not to do it because it's not >> really a bug fix (it makes the kernel slightly more restrictive about >> what it accepts from userspace than is necessary but no OVS userspace >> ever generates requests that don't conform) so it's mostly about >> squelching a compiler warning. From that perspective, it doesn't >> really seem like stable branch material. >> >> I guess it's mostly a backporting error, so maybe it can be considered >> a bug. I guess it's fine to push if you want. >> Acked-by: Jesse Gross <[email protected]> > > > Are you suggesting that we revert the original patch or that we don't use my > patch? I don't like shipping software with compiler warnings, and since the > warning was introduced post-1.2.1, I'd like to get rid of the warning. I can > also reduce the patch to only remove the "done" label.
Not using the patch. I don't think making changes for the sole purpose of removing compiler warnings is a particularly good justification for doing something on a stable branch. I think the strongest argument in favor of this patch is actually correcting the behavior, not the warning. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
