On Fri, Sep 23, 2011 at 03:32:31PM -0700, Justin Pettit wrote:
>                  cmd_output(CAP_NETWORK_STATUS,
> -                           [OVS_APPCTL, '-t', '/var/run/ovs-vswitchd.%s.ctl' 
> % vspid, '-e' 'bond/show %s' % b],
> +                           [OVS_APPCTL, '-t', '@RUNDIR@/ovs-vswitchd.%s.ctl' 
> % vspid, '-e' 'bond/show %s' % b],
>                             'ovs-appctl-bond-show-%s.out' % b)

The commit message implies (to my mind) that this is just a nit that
we are correcting, but in fact it's a bug fix because @RUNDIR@ isn't
just /var/run, it's actually /var/run/openvswitch, and the latter is
where these files actually live.

So it looks good to me but I'd like the commit message to be improved.

Thanks,

Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to