On Sep 29, 2011, at 3:42 PM, Ben Pfaff wrote:
> On Thu, Sep 29, 2011 at 03:34:37PM -0700, Justin Pettit wrote:
>>
>> + for (i=0; i < shash_count(&commands); i++) {
>
> Common OVS style is to put spaces around binary operators: "i = 0;"
>
>> + const struct shash_node *node = nodes[i];
>> + const struct unixctl_command *command;
>> +
>> + command = (struct unixctl_command *)node->data;
>
> The cast is unnecessary here.
>
> Otherwise this is a nice improvement, thank you.
Thanks. I cleaned those up and will push it soon.
--Justin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
