On Mon, Oct 10, 2011 at 05:27:17PM -0700, Ethan Jackson wrote: > In some cases, a controller may want to take an interface down for > forwarding purposes, but avoid completely deconfiguring CFM and > thus lose all connectivity monitoring. The new 'cfm_opstate' > setting is a way to achieve this behavior. > --- > Here is another version.
s/opterational/operational/ in struct cfm. You may hate me for this, but here goes anyway... "opdown" is a bad name because it's negative, and "opstate" is a good name in the database because the values "up" and "down" are very clear, but "opstate" is a bad name when it's a bool because the casual reader doesn't really know what "true" and "false" mean, he has to guess. So for a bool, "opup" or "op_up" would be a better name: it's positive and the meaning of its value is clear. Of course, for struct ccm, you have to stick with opdown because 0 is the protocol-defined normal value there. Sorry about all the nitpicking. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
