On Wed, Oct 12, 2011 at 11:05 AM, Ben Pfaff <[email protected]> wrote: > On Wed, Oct 12, 2011 at 10:55:38AM -0700, Ben Pfaff wrote: >> > For vports, if there is no PID we default to using the one associated >> > with the Netlink request. I'm not sure that that is really all that >> > useful of a feature because it is easy enough for userspace to >> > explicitly set the PID to itself explicitly if that's what it wants >> > but it is inconsistent with this. I think it would be somewhat >> > difficult to have that behavior here, so should we just make PID >> > mandatory when creating datapaths and vports? >> >> OK. I'll send out a separate patch for that. > > Here you go. This is slotted in just after the patch in the subject > header. > > Build tested only. > > --8<--------------------------cut here-------------------------->8-- > > From: Ben Pfaff <[email protected]> > Date: Wed, 12 Oct 2011 11:04:10 -0700 > Subject: [PATCH] datapath: Require explicit upcall_pid for new datapaths and > vports. > > This increases consistency with the OVS_ACTION_ATTR_USERSPACE action, which > also requires an explicit pid. > > Suggested-by: Jesse Gross <[email protected]> > Signed-off-by: Ben Pfaff <[email protected]>
Thanks. Acked-by: Jesse Gross <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
